[PATCH] powerpc/book3s64: Move PPC_DT_CPU_FTRs and enable it by default

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] powerpc/book3s64: Move PPC_DT_CPU_FTRs and enable it by default

Michael Ellerman-2
The PPC_DT_CPU_FTRs is a bit misplaced in menuconfig, it shows up with
other general kernel options. It's really more at home in the "Platform
Support" section, so move it there.

Also enable it by default, for Book3s 64. It does mostly nothing unless
the device tree properties are found, and we will want it enabled
eventually in distro kernels, so turn it on to start getting more
testing.

Fixes: 5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features")
Signed-off-by: Michael Ellerman <[hidden email]>
---
 arch/powerpc/Kconfig           | 11 -----------
 arch/powerpc/platforms/Kconfig | 11 +++++++++++
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 4a4a05afcaf7..964da1891ea9 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -380,17 +380,6 @@ source "arch/powerpc/platforms/Kconfig"
 
 menu "Kernel options"
 
-config PPC_DT_CPU_FTRS
- bool "Device-tree based CPU feature discovery & setup"
- depends on PPC_BOOK3S_64
- default n
- help
-  This enables code to use a new device tree binding for describing CPU
-  compatibility and features. Saying Y here will attempt to use the new
-  binding if the firmware provides it. Currently only the skiboot
-  firmware provides this binding.
-  If you're not sure say Y.
-
 config HIGHMEM
  bool "High memory support"
  depends on PPC32
diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index 33244e3d9375..4fd64d3f5c44 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -59,6 +59,17 @@ config PPC_OF_BOOT_TRAMPOLINE
 
   In case of doubt, say Y
 
+config PPC_DT_CPU_FTRS
+ bool "Device-tree based CPU feature discovery & setup"
+ depends on PPC_BOOK3S_64
+ default y
+ help
+  This enables code to use a new device tree binding for describing CPU
+  compatibility and features. Saying Y here will attempt to use the new
+  binding if the firmware provides it. Currently only the skiboot
+  firmware provides this binding.
+  If you're not sure say Y.
+
 config UDBG_RTAS_CONSOLE
  bool "RTAS based debug console"
  depends on PPC_RTAS
--
2.7.4

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] powerpc/book3s64: Move PPC_DT_CPU_FTRs and enable it by default

Nicholas Piggin-2
On Thu,  8 Jun 2017 16:51:41 +1000
Michael Ellerman <[hidden email]> wrote:

> The PPC_DT_CPU_FTRs is a bit misplaced in menuconfig, it shows up with
> other general kernel options. It's really more at home in the "Platform
> Support" section, so move it there.
>
> Also enable it by default, for Book3s 64. It does mostly nothing unless
> the device tree properties are found, and we will want it enabled
> eventually in distro kernels, so turn it on to start getting more
> testing.
>
> Fixes: 5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features")
> Signed-off-by: Michael Ellerman <[hidden email]>

Well I'd better send the patch to enable it in firmware then.

Thanks,
Nick
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] powerpc/book3s64: Move PPC_DT_CPU_FTRs and enable it by default

Michael Ellerman-2
Nicholas Piggin <[hidden email]> writes:

> On Thu,  8 Jun 2017 16:51:41 +1000
> Michael Ellerman <[hidden email]> wrote:
>
>> The PPC_DT_CPU_FTRs is a bit misplaced in menuconfig, it shows up with
>> other general kernel options. It's really more at home in the "Platform
>> Support" section, so move it there.
>>
>> Also enable it by default, for Book3s 64. It does mostly nothing unless
>> the device tree properties are found, and we will want it enabled
>> eventually in distro kernels, so turn it on to start getting more
>> testing.
>>
>> Fixes: 5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features")
>> Signed-off-by: Michael Ellerman <[hidden email]>
>
> Well I'd better send the patch to enable it in firmware then.

At some point :)

It actually matters less when it goes into firmware, but yeah I think
it's sufficiently cooked that it should go in.

cheers
Reply | Threaded
Open this post in threaded view
|

Re: powerpc/book3s64: Move PPC_DT_CPU_FTRs and enable it by default

Michael Ellerman-3
In reply to this post by Michael Ellerman-2
On Thu, 2017-06-08 at 06:51:41 UTC, Michael Ellerman wrote:

> The PPC_DT_CPU_FTRs is a bit misplaced in menuconfig, it shows up with
> other general kernel options. It's really more at home in the "Platform
> Support" section, so move it there.
>
> Also enable it by default, for Book3s 64. It does mostly nothing unless
> the device tree properties are found, and we will want it enabled
> eventually in distro kernels, so turn it on to start getting more
> testing.
>
> Fixes: 5a61ef74f269 ("powerpc/64s: Support new device tree binding for discovering CPU features")
> Signed-off-by: Michael Ellerman <[hidden email]>

Applied to powerpc fixes.

https://git.kernel.org/powerpc/c/c6ee9619e2edd9912316f7e2eaf9ff

cheers